Restore tests and stubs previously moved to dls-bluesky-core #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
DiamondJoseph
commented
Feb 21, 2024
DiamondJoseph
commented
- Wrapped Bluesky plans only required for BlueAPI, able to expose through new scratch dir
abbiemery
requested changes
Feb 23, 2024
| @@ -26,7 +26,6 @@ dependencies = [ | |||
| "fastapi[all]<0.99", | |||
| "uvicorn", | |||
| "requests", | |||
There was a problem hiding this comment.
There appear to be some references left to this removed package that are failing the tests.
- Wrapped Bluesky plans only required for BlueAPI, able to expose through new scratch dir
DiamondJoseph
force-pushed
the
merge-dls-bluesky-core
branch
from
a324d55
to
8348b81
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.