Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hook directory provider into run engine #476

Closed
wants to merge 4 commits into from

Conversation

callumforrester
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented May 31, 2024

Codecov Report

Attention: Patch coverage is 52.50000% with 19 lines in your changes missing coverage. Please review.

Project coverage is 90.72%. Comparing base (24441af) to head (30aa0e8).

Files Patch % Lines
src/blueapi/core/scan_id.py 54.54% 15 Missing ⚠️
src/blueapi/core/context.py 42.85% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #476      +/-   ##
==========================================
- Coverage   91.51%   90.72%   -0.80%     
==========================================
  Files          42       43       +1     
  Lines        1933     1973      +40     
==========================================
+ Hits         1769     1790      +21     
- Misses        164      183      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stan-dot
Copy link
Collaborator

ophyd-async does not use directory provider anymore, but pathprovider instead - at least the name of this PR needs to change

@callumforrester
Copy link
Collaborator Author

We need to wait for bluesky/ophyd-async#314 and ACQP-150 (jira) before we can really start this anyway now. I'll close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants