Refactor client logic out of CLI #548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
callumforrester
force-pushed
the
547-move-client-logic
branch
from
c339858
to
b4c90bd
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #548 +/- ##
==========================================
+ Coverage 90.21% 93.13% +2.92%
==========================================
Files 41 42 +1
Lines 1829 1865 +36
==========================================
+ Hits 1650 1737 +87
+ Misses 179 128 -51 ☔ View full report in Codecov by Sentry. |
callumforrester
force-pushed
the
547-move-client-logic
branch
2 times, most recently
from
0f2c772
to
204af0d
Compare
callumforrester
force-pushed
the
547-move-client-logic
branch
3 times, most recently
from
ac909b2
to
be44e2f
Compare
DiamondJoseph
approved these changes
Jul 10, 2024
callumforrester
force-pushed
the
547-move-client-logic
branch
from
44a1377
to
8c4dded
Compare
|
Some of the coverage issues might be helped by #538, so will defer until then |
callumforrester
force-pushed
the
547-move-client-logic
branch
from
8c4dded
to
168f501
Compare
callumforrester
force-pushed
the
547-move-client-logic
branch
from
e6d8cf8
to
ee1bfbb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #547