Include convenience bash script for running rabbit mq locally #668
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #668 +/- ##
=======================================
Coverage 92.62% 92.62%
=======================================
Files 35 35
Lines 1654 1654
=======================================
Hits 1532 1532
Misses 122 122 ☔ View full report in Codecov by Sentry. |
src/script/rabbitmq_setup/Dockerfile
Outdated
There was a problem hiding this comment.
Should: If possible, I would like to use an image from dockerhub rather than build our own. Do we know of any that give us what we want (STOMP plugin etc.)?
Paging @DiamondJoseph
…script-for-running-RabbitMQ-locally
| An example of a config file that starts STOMP with default values can be found in: | ||
|
|
||
| ``` | ||
| src/script/stomp_config.yml | ||
| ``` | ||
|
|
There was a problem hiding this comment.
Should: As above with ActiveMQ vs RabbitMQ, if we're going to make rabbitMQ the default for new users then maybe this should be the default config?
There was a problem hiding this comment.
It used to be, but I changed it. I think it's important for a complete beginner to clone -> build -> run with no extra steps, because once you add 1 extra step it's very easy to get into a "just one more..." mentality. The message bus is an optional feature that adds rich feedback and that we use in production, but configuring it is part 2 of the tutorial.
|
@Relm-Arrowny |
There was a problem hiding this comment.
My comments on the docs are addressed by #674, thanks @callumforrester
|
The sonarcloud error should be fixed by #664 |
docs/tutorials/quickstart.md
Outdated
| @@ -17,6 +24,7 @@ way to start it is to run it via a container: | |||
| podman run -it --rm --net host rmohr/activemq:5.15.9-alpine | |||
There was a problem hiding this comment.
Should: Also remove this reference to activemq
There was a problem hiding this comment.
I have removed activemq reference, a couple of things I notice while doing so which are the side effects of removing the Stomp default:
- The cli will forget/reload the env every time so
blueapi controller run count '{"detectors": ["current_det", "image_det"]}
in the quickstart guide will not work unless we set the env with add env loading #649 or do
blueapi -c src/script/stomp_config.yml controller run count '{"detectors": ["current_det", "image_det"]}' blueapi servewill technically work but there will be half a page of warning ever 10 secs.
fix #615