Skip to content

Commit

Permalink
Fix readme more (#33)
Browse files Browse the repository at this point in the history
* update readme

* remove container CI
  • Loading branch information
dperl-dls authored Jun 12, 2024
1 parent 0bd0d2e commit ed73789
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 65 deletions.
56 changes: 0 additions & 56 deletions .github/workflows/_container.yml

This file was deleted.

7 changes: 0 additions & 7 deletions .github/workflows/backend_ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,13 +38,6 @@ jobs:
secrets:
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}

container:
needs: check
if: needs.check.outputs.branch-pr == ''
uses: ./.github/workflows/_container.yml
permissions:
packages: write

dist:
needs: check
if: needs.check.outputs.branch-pr == ''
Expand Down
6 changes: 5 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,14 @@
[![PyPI](https://img.shields.io/pypi/v/daq-config-server.svg)](https://pypi.org/project/daq-config-server)
[![License](https://img.shields.io/badge/License-Apache%202.0-blue.svg)](https://opensource.org/licenses/Apache-2.0)

# daq_config_server
# DAQ Config Server

A service to put and get your config values from.

Comprises a FastAPI backend with a valkey database to C/R/U/D config values, and a Chakra/React frontend for easier management.

Currently the scope is JUST storing and retrieving feature flags for Hyperion/I03 UDC but we hope to expand this to replace all DAQ config files.

| Source | <https://github.com/DiamondLightSource/daq-config-server> |
| :------: | :----------------------------------------------------------------: |
| Docker | `docker run ghcr.io/DiamondLightSource/daq-config-server:latest` |
Expand Down
1 change: 1 addition & 0 deletions gui/config-server-gui/src/App.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,7 @@ export const App = () => {
placeholder="flag_name"
size="md"
onChange={handleChange}
onKeyDown={(event) => event.key === "Enter" && submitCreateFlag()}
></Input>
<InputRightElement
children={
Expand Down
2 changes: 1 addition & 1 deletion tests/test_api.py
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ async def test_get_one_beamlineparam(self, mock_app):

@patch("daq_config_server.app.valkey")
async def test_get_feature_list(self, mock_valkey: MagicMock, mock_app):
test_param_list = ["param_1", "param_2", "param_3"]
test_param_list = ["param_1", "param_2", "param_3", "param_4"]
mock_valkey.smembers.return_value = test_param_list
await _assert_get_and_response(
mock_app,
Expand Down

0 comments on commit ed73789

Please sign in to comment.