(#378) Fix test failures due to missing decorator parentheses. Add mi…

…ssing pyright plugin to dependencies

pyproject.toml

@@ -50,6 +50,7 @@ dev = [
     "psutil",
     "pydata-sphinx-theme>=0.12",
     "pyright",
+    "pyright_diff_quality_plugin @ git+https://github.com/DiamondLightSource/pyright_diff_quality_plugin.git",
     "pytest",
     "pytest-asyncio",
     "pytest-cov",

src/dodal/beamlines/i22.py

@@ -234,7 +234,7 @@ def slits_3(
     )
 
 
-@skip_device
+@skip_device()
 def slits_4(
     wait_for_connection: bool = True,
     fake_with_ophyd_sim: bool = False,
@@ -300,7 +300,7 @@ def panda1(
     )
 
 
-@skip_device
+@skip_device()
 def panda2(
     wait_for_connection: bool = True,
     fake_with_ophyd_sim: bool = False,
@@ -315,7 +315,7 @@ def panda2(
     )
 
 
-@skip_device
+@skip_device()
 def panda3(
     wait_for_connection: bool = True,
     fake_with_ophyd_sim: bool = False,
@@ -330,7 +330,7 @@ def panda3(
     )
 
 
-@skip_device
+@skip_device()
 def panda4(
     wait_for_connection: bool = True,
     fake_with_ophyd_sim: bool = False,
@@ -366,7 +366,7 @@ def oav(
     )
 
 
-@skip_device
+@skip_device()
 def linkam(
     wait_for_connection: bool = True, fake_with_ophyd_sim: bool = False
 ) -> Linkam3:

src/dodal/beamlines/p38.py

@@ -55,7 +55,7 @@ def d3(
 
 
 # Disconnected
-@skip_device
+@skip_device()
 def d11(
     wait_for_connection: bool = True, fake_with_ophyd_sim: bool = False
 ) -> AravisDetector:
@@ -262,7 +262,7 @@ def undulator(
 # Must find which PandA IOC(s) are compatible
 # Must document what PandAs are physically connected to
 # See: https://github.com/bluesky/ophyd-async/issues/284
-@skip_device
+@skip_device()
 def panda1(
     wait_for_connection: bool = True,
     fake_with_ophyd_sim: bool = False,
@@ -277,7 +277,7 @@ def panda1(
     )
 
 
-@skip_device
+@skip_device()
 def panda2(
     wait_for_connection: bool = True,
     fake_with_ophyd_sim: bool = False,
@@ -292,7 +292,7 @@ def panda2(
     )
 
 
-@skip_device
+@skip_device()
 def panda3(
     wait_for_connection: bool = True,
     fake_with_ophyd_sim: bool = False,
@@ -307,7 +307,7 @@ def panda3(
     )
 
 
-@skip_device
+@skip_device()
 def linkam(
     wait_for_connection: bool = True, fake_with_ophyd_sim: bool = False
 ) -> Linkam3:

src/dodal/beamlines/p45.py

@@ -48,7 +48,7 @@ def choppers(
 
 
 # Disconnected
-@skip_device
+@skip_device()
 def det(
     wait_for_connection: bool = True, fake_with_ophyd_sim: bool = False
 ) -> AravisDetector:
@@ -65,7 +65,7 @@ def det(
 
 
 # Disconnected
-@skip_device
+@skip_device()
 def diff(
     wait_for_connection: bool = True, fake_with_ophyd_sim: bool = False
 ) -> AravisDetector:
@@ -84,7 +84,7 @@ def diff(
 # Must find which PandA IOC(s) are compatible
 # Must document what PandAs are physically connected to
 # See: https://github.com/bluesky/ophyd-async/issues/284
-@skip_device
+@skip_device()
 def panda1(
     wait_for_connection: bool = True,
     fake_with_ophyd_sim: bool = False,
@@ -99,7 +99,7 @@ def panda1(
     )
 
 
-@skip_device
+@skip_device()
 def panda2(
     wait_for_connection: bool = True,
     fake_with_ophyd_sim: bool = False,