Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create device for i22 slits_4 #587

Closed
DiamondJoseph opened this issue May 30, 2024 · 3 comments · Fixed by #762
Closed

Create device for i22 slits_4 #587

DiamondJoseph opened this issue May 30, 2024 · 3 comments · Fixed by #762
Assignees
@stan-dot

Comments

@DiamondJoseph
Copy link
Contributor

i22's slits_4 has different PVs than its other slits, a representation of this device is required along with the existing slits.

Acceptance Criteria

  • Specific criteria that will be used to judge if the issue is fixed
@DiamondJoseph DiamondJoseph mentioned this issue May 30, 2024
Merged
@abbiemery
Copy link
Contributor

abbiemery commented May 30, 2024 •
edited

Once this is fixed, put them back into the plan in i22-bluesky (un-comment them out).

@DominicOram
Copy link
Contributor

We had the same thing on i03 where some of the slits had different PVs and asked controls to add alias' on their side, could we do that here too?

@stan-dot stan-dot self-assigned this Jul 9, 2024
@DiamondJoseph DiamondJoseph mentioned this issue Jul 9, 2024
Closed
@stan-dot
Copy link
Contributor

stan-dot commented Jul 15, 2024 •
edited

Slit x_centre, x_gap, y_centre, y_gap

and
name, physical, derived axes:
Slit | X_plus, X_minus, Y_plus, Y_minus | X_centre, Y_centre, X_size, Y_size

@DiamondJoseph I extracted that from the issue, I'll call it Slit Special for i22 or something different?

@stan-dot stan-dot mentioned this issue Jul 15, 2024
Closed
@stan-dot stan-dot linked a pull request Jul 15, 2024 that will close this issue
Add a simple version to fill the unique needs of slit4 #672
Closed
@stan-dot stan-dot mentioned this issue Aug 5, 2024
Open
@stan-dot stan-dot mentioned this issue Aug 22, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stan-dot stan-dot

Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@DominicOram @DiamondJoseph @stan-dot @abbiemery