Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove skip device #762

Merged
merged 1 commit into from
Aug 22, 2024
Merged

remove skip device #762

merged 1 commit into from
Aug 22, 2024

Conversation

stan-dot
Copy link
Contributor

Fixes #587

Instructions to reviewer on how to test:

  1. run dodal connect i22
  2. Expect all the slits, including 4 to connect

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@stan-dot stan-dot added enhancement New feature or request python Pull requests that update Python code i22 labels Aug 22, 2024
@stan-dot stan-dot self-assigned this Aug 22, 2024
Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.46%. Comparing base (d4685c0) to head (29911a0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #762      +/-   ##
==========================================
- Coverage   94.47%   94.46%   -0.01%     
==========================================
  Files         116      116              
  Lines        4612     4611       -1     
==========================================
- Hits         4357     4356       -1     
  Misses        255      255              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stan-dot stan-dot merged commit 1ff9784 into main Aug 22, 2024
20 checks passed
@stan-dot stan-dot deleted the uncomment-i22-slit-4 branch August 22, 2024 15:16
stan-dot added a commit that referenced this pull request Aug 27, 2024
stan-dot added a commit that referenced this pull request Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request i22 python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create device for i22 slits_4
2 participants