-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Container Build from CI #388
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #388 +/- ##
=======================================
Coverage 93.45% 93.45%
=======================================
Files 90 90
Lines 3376 3376
=======================================
Hits 3155 3155
Misses 221 221 ☔ View full report in Codecov by Sentry. |
Should remove the "Run in a Container" page of the docs too if we remove the container build. Is there a ticket for switching to the Copier template? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the "Run in a Container" user docs too
Done, can make a ticket for copier |
If you could, then we can discuss with MX about whether we want to adopt or not. It should be comparatively simple as already using skeleton |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks!
Fixes ongoing issues in CI caused by dependency pinning
Dodal in a container is not used and building conflicts with ophyd-async dependency pinning often, slowing down the merging of some pull requests. This PR removes it, which will hopefully speed things up.
Instructions to reviewer on how to test:
Checks for reviewer