Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Container Build from CI #388

Merged
merged 3 commits into from
Mar 18, 2024
Merged

Conversation

callumforrester
Copy link
Contributor

Fixes ongoing issues in CI caused by dependency pinning
Dodal in a container is not used and building conflicts with ophyd-async dependency pinning often, slowing down the merging of some pull requests. This PR removes it, which will hopefully speed things up.

Instructions to reviewer on how to test:

  1. Ensure CI still passes

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards

Copy link

codecov bot commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.45%. Comparing base (c79e882) to head (d5fa814).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #388   +/-   ##
=======================================
  Coverage   93.45%   93.45%           
=======================================
  Files          90       90           
  Lines        3376     3376           
=======================================
  Hits         3155     3155           
  Misses        221      221           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DiamondJoseph
Copy link
Contributor

Should remove the "Run in a Container" page of the docs too if we remove the container build.

Is there a ticket for switching to the Copier template?

Copy link
Contributor

@DiamondJoseph DiamondJoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the "Run in a Container" user docs too

@callumforrester
Copy link
Contributor Author

Done, can make a ticket for copier

@DiamondJoseph
Copy link
Contributor

Done, can make a ticket for copier

If you could, then we can discuss with MX about whether we want to adopt or not. It should be comparatively simple as already using skeleton

@DominicOram
Copy link
Contributor

DominicOram commented Mar 18, 2024

Is there a ticket for switching to the Copier template?

#378

Copy link
Contributor

@DominicOram DominicOram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@callumforrester callumforrester merged commit 30815f1 into main Mar 18, 2024
14 checks passed
@callumforrester callumforrester deleted the remove-container-build branch March 18, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants