Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated p38 devices to work with Ophyd_async changes #392

Draft
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

DiamondJoseph
Copy link
Contributor

Fixes #ISSUE

Instructions to reviewer on how to test:

  1. Do thing x
  2. Confirm thing y happens

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards

@DiamondJoseph
Copy link
Contributor Author

Requires changes in ophyd_async on the same named branch. p38 TetrAMM now deployed with later version of the ioc that adds the acquire_rbv signal so can be reverted (ensures compatibility with the i22 TetrAMM: TetrAMM class should be noted that only supports latest version of the TetrAMM Epics driver

@DiamondJoseph
Copy link
Contributor Author

Includes update to the device instantiation for ophyd_async devices that should be seperated into its own PR

@DiamondJoseph
Copy link
Contributor Author

Needs to be seperated from i22 changes as much as is sensible. i22 changes can simplify enum handling with even newer changes of ophyd_async.
Bluesky dependency is just main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant