-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update AdSim devices and configuration to use ophyd-async #405
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #405 +/- ##
==========================================
+ Coverage 94.43% 94.77% +0.34%
==========================================
Files 112 112
Lines 4531 4540 +9
==========================================
+ Hits 4279 4303 +24
+ Misses 252 237 -15 ☔ View full report in Codecov by Sentry. |
e865779
to
cb9d72d
Compare
@Relm-Arrowny you've done some simulation work for p99 afaik, how useful is this PR? |
It nice to have, at the moment I either use fake or something from bluesky.sim so being able to just add area detector without thinking about it would save time. |
How far does e.g. def det(
wait_for_connection: bool = True, fake_with_ophyd_sim: bool = True
) -> AravisDetector:
return device_instantiation(
AravisDetector,
"det",
"-EA-MAP-01:",
wait_for_connection,
fake_with_ophyd_sim,
directory_provider=get_directory_provider(),
) |
It got me as far as getting arming/trigger to work so I can use it to test plans and emitted the right docs. This is an example of what I do atm. |
ecab867
to
5e2187e
Compare
|
||
class AdSimDetector(StandardDetector, HasHints): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the only place sim_detector is present and it is not exported
Should I increase the version of ophyd_async but it will be a big change
ophyd-version is 0.3.4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I didn't realise that we hadn't updated to ophyd-async yet. Let's find out who's doing that.
28b38d4
to
dab2061
Compare
Fixes #404
Instructions to reviewer on how to test:
Checks for reviewer