-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
432 create sample stage device for p99 #458
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry to jump in here without knowing much background. I've put some minor comments in the code. In general I'm not sure I like that we have to have a SetReadOnlyMotor
as I'm not sure this is the right solution in general. Has the possibility of wrapping a SoftMotor
around it in IOC been discussed with controls? Then the implementation details get hidden from the ophyd layer and up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I completely forgot that I started reviewing this. One comment, it also looks like it won't work with the latest main
as beamline_utils
has been renamed. Otherwise happy to merge.
src/dodal/devices/stages.py
Outdated
from ophyd_async.epics.motion.motor import Motor | ||
|
||
|
||
class ThreeAxisStage(Device): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should: Can we combine this with XYZPositioner
Do you still need this @Relm-Arrowny? Would be good to get it merged if useful or dropped otherwise, just so we don't have too many stale PRs |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #458 +/- ##
==========================================
+ Coverage 94.43% 94.49% +0.05%
==========================================
Files 112 114 +2
Lines 4531 4579 +48
==========================================
+ Hits 4279 4327 +48
Misses 252 252 ☔ View full report in Codecov by Sentry. |
Sorry p99 is being move and this slipped my mine, it should be good to go. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thank you! I couldn't test that the PVs are right as I couldn't ssh
into P99, maybe it's down? So going to trust you on that. Otherwise just one suggestion, which I will fix myself quickly
src/dodal/devices/motors.py
Outdated
xyz_stage = ThreeAxisStage("BLXX-MO-STAGE-XX:") | ||
Or:: | ||
with DeviceCollector(): | ||
xyz_stage = ThreeAxisStage("BLXX-MO-STAGE-XX:", suffix = [".any", | ||
".there", ".motorPv"]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should: Docs now reference the old device name, I will fix
Fixes #432 see p99#7 and p99#13 for full detail
Added :
Instructions to reviewer on how to test:
Checks for reviewer