Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make device factory decorator #597

Open
wants to merge 52 commits into
base: main
Choose a base branch
from
Open

make device factory decorator #597

wants to merge 52 commits into from

Commits on Sep 13, 2024

  1. example beamline with implementation

    @stan-dot
    stan-dot committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    b862249 View commit details
    Browse the repository at this point in the history

  2. small cleanup

    @stan-dot
    stan-dot committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    371e49c View commit details
    Browse the repository at this point in the history

  3. added controller demonstration

    @stan-dot
    stan-dot committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    c6183bb View commit details
    Browse the repository at this point in the history

  4. fix wrong extension

    @stan-dot
    stan-dot committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    992ce0c View commit details
    Browse the repository at this point in the history

  5. Update src/dodal/beamlines/example_beamline.py 

    Co-authored-by: Tom C (DLS) <[email protected]>
    @stan-dot @coretl
    stan-dot and coretl committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    cb02123 View commit details
    Browse the repository at this point in the history

  6. Update src/dodal/beamlines/example_beamline.py 

    Co-authored-by: Tom C (DLS) <[email protected]>
    @stan-dot @coretl
    stan-dot and coretl committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    861c713 View commit details
    Browse the repository at this point in the history

  7. Update src/dodal/beamlines/example_beamline.py 

    Co-authored-by: Tom C (DLS) <[email protected]>
    @stan-dot @coretl
    stan-dot and coretl committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    bd54d7a View commit details
    Browse the repository at this point in the history

  8. Update src/dodal/beamlines/example_beamline.py 

    Co-authored-by: Tom C (DLS) <[email protected]>
    @stan-dot @coretl
    stan-dot and coretl committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    faf7fc7 View commit details
    Browse the repository at this point in the history

  9. fix example beamline into a dataclass

    @stan-dot
    stan-dot committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    88833c7 View commit details
    Browse the repository at this point in the history

  10. new-i22 as an example

    @stan-dot
    stan-dot committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    4199909 View commit details
    Browse the repository at this point in the history

  11. respond to feedback

    @stan-dot
    stan-dot committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    64d9a65 View commit details
    Browse the repository at this point in the history

  12. respond to comments

    @stan-dot
    stan-dot committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    2ded84e View commit details
    Browse the repository at this point in the history

  13. initial test

    @stan-dot
    stan-dot committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    d0eabcf View commit details
    Browse the repository at this point in the history

  14. comment out some tests to check coverage

    @stan-dot
    stan-dot committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    6c674a2 View commit details
    Browse the repository at this point in the history

  15. lint

    @stan-dot
    stan-dot committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    1e2e12f View commit details
    Browse the repository at this point in the history

  16. use factory name for active devices dict key

    @stan-dot
    stan-dot committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    7a33b22 View commit details
    Browse the repository at this point in the history

  17. this cannot be active devices, globals harder to mock

    @stan-dot
    stan-dot committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    443ca48 View commit details
    Browse the repository at this point in the history

  18. amend the test

    @stan-dot
    stan-dot committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    cd3a66f View commit details
    Browse the repository at this point in the history

  19. added a red test for caching by name

    @stan-dot
    stan-dot committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    a17af52 View commit details
    Browse the repository at this point in the history

  20. fix the tests and add the support for a name flag

    @stan-dot
    stan-dot committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    d7cc09e View commit details
    Browse the repository at this point in the history

  21. add the API for blueapi

    @stan-dot
    stan-dot committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    28ac863 View commit details
    Browse the repository at this point in the history

  22. remove todos

    @stan-dot
    stan-dot committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    a27a983 View commit details
    Browse the repository at this point in the history

  23. unused utils deleted for coverage

    @stan-dot
    stan-dot committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    2589824 View commit details
    Browse the repository at this point in the history

  24. Just one i22 now

    @stan-dot
    stan-dot committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    03b54b9 View commit details
    Browse the repository at this point in the history

  25. respond to comments

    @stan-dot
    stan-dot committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    b47221d View commit details
    Browse the repository at this point in the history

  26. rename to device factory

    @stan-dot
    stan-dot committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    c158735 View commit details
    Browse the repository at this point in the history

  27. is this enough to replace skip_device()

    @stan-dot
    stan-dot committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    1bf2909 View commit details
    Browse the repository at this point in the history

  28. ruff

    @stan-dot
    stan-dot committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    74c5093 View commit details
    Browse the repository at this point in the history

  29. remove the connect default timeout =10

    @stan-dot
    stan-dot committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    ae0dfe6 View commit details
    Browse the repository at this point in the history

  30. add support for the terminal use case and some tests

    @stan-dot
    stan-dot committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    926da27 View commit details
    Browse the repository at this point in the history

  31. fix mock status and add the new decorator@

    @stan-dot
    stan-dot committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    c6c2fad View commit details
    Browse the repository at this point in the history

  32. fix the tests

    @stan-dot
    stan-dot committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    1550a83 View commit details
    Browse the repository at this point in the history

  33. delete bad comments, add good comments

    @stan-dot
    stan-dot committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    4e2d0c3 View commit details
    Browse the repository at this point in the history

  34. ruff

    @stan-dot
    stan-dot committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    7df2b64 View commit details
    Browse the repository at this point in the history

  35. feedback response

    @stan-dot
    stan-dot committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    3990818 View commit details
    Browse the repository at this point in the history

  36. add return type annotation for testing coverage purposes

    @stan-dot
    stan-dot committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    ff80ab7 View commit details
    Browse the repository at this point in the history

  37. respond to feedback

    @stan-dot
    stan-dot committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    528016d View commit details
    Browse the repository at this point in the history

  38. adapt tetramm

    @stan-dot
    stan-dot committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    3e96bd9 View commit details
    Browse the repository at this point in the history

  39. respond to feedback

    @stan-dot
    stan-dot committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    a1500e8 View commit details
    Browse the repository at this point in the history

  40. add repr that includes the config

    @stan-dot
    stan-dot committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    5050a3c View commit details
    Browse the repository at this point in the history

  41. lint

    @stan-dot
    stan-dot committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    e7acd12 View commit details
    Browse the repository at this point in the history

  42. remove old panda ref

    @stan-dot
    stan-dot committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    9d3016f View commit details
    Browse the repository at this point in the history

  43. fix import

    @stan-dot
    stan-dot committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    83a6974 View commit details
    Browse the repository at this point in the history

  44. fix the tests

    @stan-dot
    stan-dot committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    a13b7ca View commit details
    Browse the repository at this point in the history

  45. pin pyright version due to is_device check failing

    @stan-dot
    stan-dot committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    d6fe8c6 View commit details
    Browse the repository at this point in the history

  46. cancel pyright pinning

    @stan-dot
    stan-dot committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    97fdc29 View commit details
    Browse the repository at this point in the history

  47. renaming

    @stan-dot
    stan-dot committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    5a5a0c7 View commit details
    Browse the repository at this point in the history

  48. partial update to fix the test coverage for the factory

    @stan-dot
    stan-dot committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    21df367 View commit details
    Browse the repository at this point in the history

  49. maybe fixed

    @stan-dot
    stan-dot committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    0779785 View commit details
    Browse the repository at this point in the history

  50. imports fix

    @stan-dot
    stan-dot committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    982c1a2 View commit details
    Browse the repository at this point in the history

  51. fix imports

    @stan-dot
    stan-dot committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    422a87b View commit details
    Browse the repository at this point in the history

  52. forgot one

    @stan-dot
    stan-dot committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    67e9a76 View commit details
    Browse the repository at this point in the history