Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a dcm device for I24 #652

Merged
merged 4 commits into from
Jul 19, 2024
Merged

Add a dcm device for I24 #652

merged 4 commits into from
Jul 19, 2024

Conversation

noemifrisina
Copy link
Collaborator

Needed for MX#115

A basic dcm device for I24. Fairly similar to the i22 device but a couple of small differences (mainly PV nomenclature) didn't allow for connection to work.

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

Copy link
Collaborator

@olliesilvester olliesilvester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and dodal connect i24 works. As discussed, we should work on getting the base DCM device soon, as this is the 3rd version in dodal

@noemifrisina noemifrisina merged commit e4c3d5a into main Jul 19, 2024
11 checks passed
@noemifrisina noemifrisina deleted the mx_115-make-a-dcm-for-i24 branch July 19, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants