Create util for caching positions before a plan and returning to them afterwards #653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DominicOram
changed the title
dperl-dls
requested changes
Jul 18, 2024
src/dodal/plans/motor_util_plans.py
Outdated
| def home_and_reset_wrapper( | ||
| plan: MsgGenerator, | ||
| device: Device, | ||
| home_position: float, |
There was a problem hiding this comment.
are we likely to ever have this not be 0, and if it is ever not 0 isn't it then likely to be different for every motor?
how would you feel about this instead taking a list of motors, and a list of homes or default to 0 for everything?
There was a problem hiding this comment.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #653 +/- ##
==========================================
+ Coverage 94.16% 94.24% +0.07%
==========================================
Files 108 110 +2
Lines 4305 4360 +55
==========================================
+ Hits 4054 4109 +55
Misses 251 251 ☔ View full report in Codecov by Sentry. |
stan-dot
pushed a commit
that referenced
this pull request
Jul 24, 2024
… afterwards (#653) * Added wrapper to home and reset to cache, also moved patch_motor to more easily accessible place * Made the API for the caching and moving wrapper more generic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes DiamondLightSource/hyperion#1439
Instructions to reviewer on how to test:
Checks for reviewer
dodal connect ${BEAMLINE}