Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a run_program to the pmac #661

Merged
merged 20 commits into from
Jul 26, 2024
Merged

Add a run_program to the pmac #661

merged 20 commits into from
Jul 26, 2024

Conversation

noemifrisina
Copy link
Collaborator

Fixes #650

Add a run_program to the PMAC device for I24, that sets the pmac_string to the program number and then waits for the collection to be done by checking the scanstatus PV value. It only returns when this PV returns 0.

Instructions to reviewer on how to test:

  1. Run tests

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

Copy link
Collaborator

@dperl-dls dperl-dls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Comment on lines 126 to 128
async for reading in observe_value(self.status):
if reading == ScanState.DONE:
return
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could: Can you not just use wait_for_value here?

Copy link

codecov bot commented Jul 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.26%. Comparing base (cfcea2e) to head (24ef698).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #661      +/-   ##
==========================================
+ Coverage   94.24%   94.26%   +0.02%     
==========================================
  Files         110      110              
  Lines        4360     4376      +16     
==========================================
+ Hits         4109     4125      +16     
  Misses        251      251              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@noemifrisina noemifrisina merged commit f4c703d into main Jul 26, 2024
18 checks passed
@noemifrisina noemifrisina deleted the 650_PMAC-run-program branch July 26, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PMAC: Have a run program that we can wait for
3 participants