-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a run_program to the pmac #661
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
src/dodal/devices/i24/pmac.py
Outdated
async for reading in observe_value(self.status): | ||
if reading == ScanState.DONE: | ||
return |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could: Can you not just use wait_for_value
here?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #661 +/- ##
==========================================
+ Coverage 94.24% 94.26% +0.02%
==========================================
Files 110 110
Lines 4360 4376 +16
==========================================
+ Hits 4109 4125 +16
Misses 251 251 ☔ View full report in Codecov by Sentry. |
e324427
to
3386c7e
Compare
…dodal into 650_PMAC-run-program
…dodal into 650_PMAC-run-program
679d671
to
d3bde8e
Compare
…dodal into 650_PMAC-run-program
…dodal into 650_PMAC-run-program
Fixes #650
Add a
run_program
to the PMAC device for I24, that sets thepmac_string
to the program number and then waits for the collection to be done by checking thescanstatus
PV value. It only returns when this PV returns 0.Instructions to reviewer on how to test:
Checks for reviewer
dodal connect ${BEAMLINE}