(DiamondLightSource/dodal#751) Draw crosshairs with better contrast #787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #787 +/- ##
=======================================
Coverage 94.91% 94.91%
=======================================
Files 115 115
Lines 4658 4665 +7
=======================================
+ Hits 4421 4428 +7
Misses 237 237 ☔ View full report in Codecov by Sentry. |
DominicOram
approved these changes
Sep 13, 2024
Comment on lines
112
to
119
| draw.rectangle( | ||
| [beam_x - 1, beam_y - HALF_LEN - 1, beam_x + 1, beam_y + HALF_LEN + 1], | ||
| fill=cls.CROSSHAIR_OUTLINE_COLOUR, | ||
| ) | ||
| draw.rectangle( | ||
| [beam_x - HALF_LEN - 1, beam_y - 1, beam_x + HALF_LEN + 1, beam_y + 1], | ||
| fill=cls.CROSSHAIR_OUTLINE_COLOUR, | ||
| ) |
There was a problem hiding this comment.
Should: The 1 in here is the width of the outline right? Might be worth pulling into a constant for readability?
| @@ -91,7 +91,8 @@ class SnapshotWithBeamCentre(MJPG): | |||
| image and saves the image to disk.""" | |||
There was a problem hiding this comment.
Could: Would be good to mention the outline in the docstring
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #751
Instructions to reviewer on how to test: