Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enabling padding #183

Closed
wants to merge 8 commits into from
Closed

enabling padding #183

wants to merge 8 commits into from

Conversation

dkazanc
Copy link
Collaborator

@dkazanc dkazanc commented Oct 3, 2023

#103
Automation of padding is required for 3D methods to work smoothly in httomo

  • Auto calculation of padding based on the parameters of the method
  • Enabling padding to be an attribute for every section based on which the data in blocks AND chunks will be padded
  • Enable padding to work for the serial run
  • Enable padding to work for the parallel run
  • Adding tests for padding

@dkazanc dkazanc added the enhancement New feature or request label Oct 3, 2023
@dkazanc
Copy link
Collaborator Author

dkazanc commented Oct 6, 2023

OK, so the serial padding seems to work as expected. I worked with the median filter, but in principle it can be enabled with more memory hungry methods like FBP in order to check the slicing is performed correctly for every block. It is nice to see that the boundary effects on blocks disappear as the padding applied (look for the horizontal line).
no_padding
padded

@dkazanc
Copy link
Collaborator Author

dkazanc commented Oct 6, 2023

the parallel run doesn't work, but not because of how padding implemented for blocks, It is how unpadding is performed (or not) for chunks. It doesn't seem to crop the padded chunks at all after padding them by looking at the dimensions. This all needs to be checked.

@dkazanc dkazanc changed the base branch from gpuloop to main June 18, 2024 14:40
@dkazanc
Copy link
Collaborator Author

dkazanc commented Aug 12, 2024

closing this PR as the development moved to other branches.

@dkazanc dkazanc closed this Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants