Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Padding methods support in DB #396

Merged

Conversation

team-gpu
Copy link
Contributor

This adds support in the methods database to flag which are requiring padding. It also adds a new supporting function to calculate the padding values depending on the parameters, returning a tuple for the left and right pad values for each method.

The methods added so far are all the methods with the 3d suffix from tomopy, nothing else yet. Please check if the padding calculation functions are actually correct for these, and check if some 3d methods might have been missed. But also note that it's easy to add more in future.

(It also fixes some pytest warnings that were flagged on my box)

@yousefmoazzam
Copy link
Collaborator

Fixes #383

@yousefmoazzam yousefmoazzam linked an issue Jul 18, 2024 that may be closed by this pull request
Copy link
Collaborator

@yousefmoazzam yousefmoazzam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and tests all pass for me locally. Only a few very minor things, take them or leave them :)

httomo/runner/methods_repository_interface.py Outdated Show resolved Hide resolved
tests/test_method_query.py Outdated Show resolved Hide resolved
@team-gpu
Copy link
Contributor Author

I've addressed your comments (makes sense). Please go ahead and merge when you're happy with it otherwise.

@yousefmoazzam yousefmoazzam merged commit 1995db8 into DiamondLightSource:main Jul 19, 2024
2 of 3 checks passed
@team-gpu team-gpu deleted the feature/padding-in-method-db branch July 19, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace deprecated ansi param usage with colors param in logging
2 participants