Padding methods support in DB #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s None in normalize_sino
|
Fixes #383 |
yousefmoazzam
approved these changes
Jul 18, 2024
Co-authored-by: Yousef Moazzam <[email protected]>
|
I've addressed your comments (makes sense). Please go ahead and merge when you're happy with it otherwise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support in the methods database to flag which are requiring padding. It also adds a new supporting function to calculate the padding values depending on the parameters, returning a tuple for the left and right pad values for each method.
The methods added so far are all the methods with the
3dsuffix from tomopy, nothing else yet. Please check if the padding calculation functions are actually correct for these, and check if some 3d methods might have been missed. But also note that it's easy to add more in future.(It also fixes some pytest warnings that were flagged on my box)