CI issue fixing + tests #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
There was a problem hiding this comment.
Looks good to me 🙂
One thing I'd say is that, if multiple things are going to be changed/fixed, could everything that is being changed/fixed be accounted for?
The bits of code I've commented on, I would just like some note in the PR or something that explains the reason for the change, because otherwise some of them look kinda random (like the change in parametrisation values for the paganin memory hook test, or the pipeline stats value assertion changes - is this fixing #433 maybe?).
httomo/methods_database/packages/external/httomolibgpu/supporting_funcs/prep/phase.py
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #427
Fixes #431
Fixes #433
Checklist