Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove save parameters button #189

Merged
merged 5 commits into from
Sep 9, 2024
Merged

Remove save parameters button #189

merged 5 commits into from
Sep 9, 2024

Conversation

noemifrisina
Copy link
Contributor

@noemifrisina noemifrisina commented Aug 29, 2024 •
edited
Loading

Closes #89

Remove button to save parameters before collection on the edm.
For the moment, still write a parameter file - can be changed later.

@noemifrisina noemifrisina marked this pull request as ready for review August 30, 2024 15:21
@noemifrisina noemifrisina mentioned this pull request Aug 30, 2024
Merged
@noemifrisina noemifrisina added the I24 serial Issues relating to ssx on I24 label Aug 30, 2024
dperl-dls
dperl-dls approved these changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@dperl-dls dperl-dls left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems ok for now, can you make an issue (or link in a comment if there is already one) about not doing file IO in plans please? We should use callbacks for this.

@noemifrisina noemifrisina mentioned this pull request Sep 9, 2024
Open
@noemifrisina noemifrisina merged commit 49415a2 into main Sep 9, 2024
17 checks passed
@noemifrisina noemifrisina deleted the 89_remove-set-params-button branch September 9, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dperl-dls dperl-dls dperl-dls approved these changes

@DominicOram DominicOram Awaiting requested review from DominicOram

Assignees
No one assigned
Labels
I24 serial Issues relating to ssx on I24
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

I24 ssx: Remove button to save parameter file
2 participants
@noemifrisina @dperl-dls