Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Soft tigger STXM scan #35

Merged
merged 12 commits into from
Jul 12, 2024
Merged

Soft tigger STXM scan #35

merged 12 commits into from
Jul 12, 2024

Conversation

Relm-Arrowny
Copy link
Collaborator

@Relm-Arrowny Relm-Arrowny commented Jul 3, 2024

Fix #34

Added stxm_fast plans, see #34 for detail description.

Instructions to reviewer on how to test:

  1. Run unit tests.
  2. Please ignore jupyter_tests folder, it is mostly sandbox/record keeping for me.
  3. It should work but I am mostly worry about correctness and best practice any feedback would be much appreciated.

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards

@Relm-Arrowny Relm-Arrowny linked an issue Jul 3, 2024 that may be closed by this pull request
6 tasks
Copy link

codecov bot commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (dfce760) to head (05e8d00).

Additional details and impacted files
@@            Coverage Diff             @@
##              main       #35    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           10        14     +4     
  Lines          202       326   +124     
==========================================
+ Hits           202       326   +124     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Relm-Arrowny
Copy link
Collaborator Author

This is far from ready but am worry that this is not the right way to go about it, in pacifically the logic of this function:_fast_scan_1d. I am wondering if you have time could you have look and make sure I have not missed a better way of doing it. @DominicOram @callumforrester @stan-dot

src/p99_bluesky/plans/fast_scan.py Outdated Show resolved Hide resolved
src/p99_bluesky/plans/fast_scan.py Show resolved Hide resolved
src/p99_bluesky/plans/fast_scan.py Outdated Show resolved Hide resolved
src/p99_bluesky/plans/stxm.py Outdated Show resolved Hide resolved
src/p99_bluesky/plans/stxm.py Outdated Show resolved Hide resolved
src/p99_bluesky/plans/stxm.py Outdated Show resolved Hide resolved
@Relm-Arrowny
Copy link
Collaborator Author

Flyable motor may be better way of doing this.,

pyproject.toml Outdated Show resolved Hide resolved
tests/test_fast_scan.py Outdated Show resolved Hide resolved
tests/test_fast_scan.py Outdated Show resolved Hide resolved
tests/test_fast_scan.py Outdated Show resolved Hide resolved
@Relm-Arrowny Relm-Arrowny marked this pull request as ready for review July 9, 2024 11:43
@Relm-Arrowny Relm-Arrowny changed the title Soft tigger fly scan Soft tigger STXM scan Jul 9, 2024
@callumforrester
Copy link

@Relm-Arrowny this may be for a later PR but you should consider starting to use scanspec

@Relm-Arrowny Relm-Arrowny merged commit 62e6d81 into main Jul 12, 2024
18 checks passed
@Relm-Arrowny Relm-Arrowny deleted the 34-hit-and-hope-fly-scan branch July 12, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hit and hope fly scan.
3 participants