More rsync fixes
#360
Merged
More rsync fixes
#360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #360 +/- ##
==========================================
- Coverage 28.26% 28.19% -0.08%
==========================================
Files 71 71
Lines 9661 9686 +25
Branches 1301 1308 +7
==========================================
Hits 2731 2731
- Misses 6836 6861 +25
Partials 94 94 |
d-j-hatton
previously approved these changes
Oct 11, 2024
Co-authored by: stephen-riggs <[email protected]>
tieneupin
dismissed
d-j-hatton’s stale review
Contents of PR have changed, so will request review again when it's done
tieneupin
changed the title
rsync fixes
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
By preprending Test script I wrote to evaluate how to construct the rsync subprocess: rsync subprocess ran successfully on:
|
|
This branch was very old, so I encountered some issues when merging from 'main', but it should be all good now. This PR should be approved and pushed to main together with, but after, PR #388 to fix MSYS2 functionality. |
stephen-riggs
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A follow-up to the rsync issue raised in #318 .
Replaced the individual file warnings in
murfey.client.rsyncwith a summary message comparing the files to be transferred and the files registered as successfully transferred. This should help pinpoint whether it's a file path mismatch issue, or another condition further upstream that is not behaving as expected.Additionally, the MSYS2 environment is set up differently from Cygwin, so Python
pathlib.Pathdefaults to aWindowsPathobject instead of aPosixPathas in Cygwin. This PR also introduces additional conditions to ensure file paths are passed to the rsync daemon in the correct Unix format.