Make machine configuration extendable #392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e murfey.config entry point and validate against the provided model Also provide a convenience function for extracting the relevant part of the extended configuration from other packages if Murfey is installed
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #392 +/- ##
==========================================
+ Coverage 28.37% 28.70% +0.33%
==========================================
Files 71 71
Lines 9608 10061 +453
Branches 1284 1477 +193
==========================================
+ Hits 2726 2888 +162
- Misses 6788 7061 +273
- Partials 94 112 +18 |
stephen-riggs
approved these changes
Oct 31, 2024
|
|
||
| def get_extended_machine_config( | ||
| extension_name: str, instrument_name: str = "" | ||
| ) -> Optional[BaseModel]: |
There was a problem hiding this comment.
The return type of this isn't directly a BaseModel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow extra configuration options to be extracted from the Murfey machine configuration and validated against a pydantic model specified as an entry point. This allows external packages to add their configuration to the Murfey config for convenience