Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove decorator for recording method call failures #393

Merged
merged 2 commits into from
Oct 31, 2024
Merged

Conversation

d-j-hatton
Copy link
Contributor

@d-j-hatton d-j-hatton commented Oct 31, 2024

record_failure decorator was broken. Looks like we can just remove it

Copy link

codecov bot commented Oct 31, 2024

Codecov Report

Attention: Patch coverage is 10.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 28.46%. Comparing base (e2fdd75) to head (8c62a42).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #393      +/-   ##
==========================================
+ Coverage   28.36%   28.46%   +0.09%     
==========================================
  Files          71       71              
  Lines        9610     9644      +34     
  Branches     1285     1292       +7     
==========================================
+ Hits         2726     2745      +19     
- Misses       6790     6803      +13     
- Partials       94       96       +2     

@d-j-hatton d-j-hatton changed the title Pass arguments through wrapper Remove decorator for recording method call failures Oct 31, 2024
@d-j-hatton d-j-hatton merged commit cbdc412 into main Oct 31, 2024
17 checks passed
@d-j-hatton d-j-hatton deleted the decorator-fix branch October 31, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants