-
Notifications
You must be signed in to change notification settings - Fork 1
Enhanced functionality of cross-instrument file transfer API endpoints #680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tieneupin
wants to merge
18
commits into
main
Choose a base branch
from
improve-updstream-file-download-endpoint
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hared' and updated function name
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #680 +/- ##
==========================================
+ Coverage 35.05% 35.26% +0.21%
==========================================
Files 91 91
Lines 11161 11225 +64
Branches 1486 1487 +1
==========================================
+ Hits 3912 3959 +47
- Misses 7122 7138 +16
- Partials 127 128 +1 🚀 New features to boost your workflow:
|
…tionary, and updated functions that use it to reflect this; changed 'find_upstream_visits' to return a nested dictionary where visits are grouped by instrument name
…ent upstream instruments
…for general file downloads from different upstream instruments
b77fb76 to
355574e
Compare
d-j-hatton
reviewed
Oct 23, 2025
d-j-hatton
approved these changes
Oct 24, 2025
…ed', since we have multiple modules named 'shared'
…ut is populated when running the test offline
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
client
Relates to the client component
enhancement
New feature or request
server
Relates to the server component
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we set up endpoints to facilitate the downloading of TIFF files from a specific instrument. This approach worked as a stopgap measure, but was not easily scalable to other instruments and data types.
This PR adds new endpoints to the instrument and backend servers, along with new keys to the MachineConfig Pydantic model, that allow for file downloads to be configured on a per-instrument basis. The old TIFF file download endpoints have been left in for now for backwards compatibility, but should ideally be removed from the repo in a future PR to minimise bloat.
upstream_data_directoriesfield into a dictionary, with the data directory mapped to the instrument name. Updated file download endpoints to work with this changeupstream_data_search_stringsfield, which takes a list ofglobsearch strings for each instrumentfind_upstream_visitsFastAPI endpoint to return a nested dictionary, where the visit names and their full file paths are further grouped by instrument name