Skip to content

Conversation

@stephen-riggs
Copy link
Contributor

@stephen-riggs stephen-riggs commented Nov 21, 2025

Needs to merge with #695

Creates a common function for data collection group creation by the client. The data collection groups are made as atlases then updated to be SPA or Tomo if data collection happens.

Diff looks bigger than it really is as a test file got moved.

@codecov
Copy link

codecov bot commented Nov 21, 2025

Codecov Report

❌ Patch coverage is 60.27397% with 58 lines in your changes missing coverage. Please review.
✅ Project coverage is 40.12%. Comparing base (6aa3f3f) to head (e6ef7f4).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #696      +/-   ##
==========================================
+ Coverage   39.47%   40.12%   +0.64%     
==========================================
  Files          98       99       +1     
  Lines       11542    11577      +35     
  Branches     1537     1547      +10     
==========================================
+ Hits         4556     4645      +89     
+ Misses       6778     6715      -63     
- Partials      208      217       +9     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@stephen-riggs stephen-riggs marked this pull request as ready for review November 26, 2025 10:07
Copy link
Contributor

@tieneupin tieneupin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice work. I couldn't spot anything glaringly wrong, and the pipeline works in our test setup.

@stephen-riggs stephen-riggs merged commit 8b4803a into main Dec 9, 2025
17 checks passed
@stephen-riggs stephen-riggs deleted the match-atlas-dcgs branch December 9, 2025 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants