change btnLabelResetToDefaults string so it doesn't conflict with ButtonUpgradeLabel #827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Die4Ever
reviewed
Jun 28, 2024
| @@ -0,0 +1,7 @@ | |||
| class DXRMenuUIWindow shims MenuUIWindow; | |||
There was a problem hiding this comment.
you're making this change globally? should just be inside GUI\DeusEx\Classes\DXRMenuScreenNewGame.uc
There was a problem hiding this comment.
I think it's better for the shortcut to be consistent everywhere.
There was a problem hiding this comment.
did you check if anything uses alt+e?
There was a problem hiding this comment.
I looked through all the settings windows, but some grepping reveals I missed a couple windows. (Amusingly, the Display window already has two alt+e shortcuts.)
There was a problem hiding this comment.
I'm just going to remove the shortcut entirely from the New Game window rather than give it one that's different from everywhere else. It's not like anyone's using it on purpose anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.