fix(hooks): add matcher to UserPromptSubmit to skip no-op invocations#625
Open
pablotdv wants to merge 1 commit into
Open
fix(hooks): add matcher to UserPromptSubmit to skip no-op invocations#625pablotdv wants to merge 1 commit into
pablotdv wants to merge 1 commit into
Conversation
Without a matcher the hook fires on every prompt, spawning a PowerShell process + Node.js startup on Windows even when the prompt has nothing to do with ponytail. On slower machines or under antivirus load this easily exceeds the 5 s timeout and the hook output is silently discarded. The mode-tracker only acts on prompts that contain "ponytail" (commands like /ponytail, @Ponytail, $ponytail, "stop ponytail") or the exact deactivation phrase "normal mode". Adding that as the matcher means the hook is skipped entirely for all other prompts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without a matcher the hook fires on every prompt, spawning a PowerShell process + Node.js startup on Windows even when the prompt has nothing to do with ponytail. On slower machines or under antivirus load this easily exceeds the 5 s timeout and the hook output is silently discarded with:
The mode-tracker only acts on prompts containing "ponytail" (/ponytail, @Ponytail, $ponytail, "stop ponytail") or the exact deactivation phrase "normal mode". Adding that as the matcher means the hook is skipped entirely for all other prompts — zero process overhead on the fast path