fix(qoder): persist off mode across prompts - #676
Open
l2yujw wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On Qoder, turning Ponytail off only lasted for the current hook invocation. The next ordinary prompt treated the missing state file as first-run initialization and restored the configured default mode.
This change:
offstate on Qoder;/ponytail off,stop ponytail, andnormal mode;Root cause
Qoder has no
SessionStart, so itsUserPromptSubmitpath initializes the default mode wheneverreadMode()returns no state:The deactivation paths previously called
clearMode(). That made an intentionally disabled Qoder session indistinguishable from a session that had not been initialized yet.Fix
For Qoder, deactivation now stores
offwithsetMode('off').Other hosts retain the existing
clearMode()behavior, so the change is scoped to Qoder.Verification