Skip to content

fix(hooks): silence off-mode SessionStart #687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
connerohnesorge wants to merge 1 commit into
base: main
Choose a base branch
from
+37 −2
Open

fix(hooks): silence off-mode SessionStart #687

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions hooks/ponytail-activate.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,6 @@ const mode = getDefaultMode();
// "off" mode — skip activation entirely, don't write flag or emit rules
if (mode === 'off') {
clearMode();
const hookOutput = (isCodex || isCopilot) ? '' : 'OK';
writeHookOutput('SessionStart', 'off', hookOutput);
process.exit(0);
}

Expand Down
37 changes: 37 additions & 0 deletions tests/hooks.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,43 @@ const home = path.join(temp, 'home');
const pluginData = path.join(temp, 'plugin-data');
fs.mkdirSync(home, { recursive: true });

// Off-mode SessionStart must clear stale state without emitting model-visible
// output on any harness.
for (const { label, env, statePath } of [
{
label: 'Claude',
env: { HOME: home, USERPROFILE: home, PONYTAIL_DEFAULT_MODE: 'off' },
statePath: path.join(home, '.claude', '.ponytail-active'),
},
{
label: 'Codex',
env: {
HOME: home,
USERPROFILE: home,
PLUGIN_DATA: pluginData,
PONYTAIL_DEFAULT_MODE: 'off',
},
statePath: path.join(pluginData, '.ponytail-active'),
},
{
label: 'Copilot',
env: {
HOME: home,
USERPROFILE: home,
COPILOT_PLUGIN_DATA: path.join(temp, 'copilot-off-data'),
PONYTAIL_DEFAULT_MODE: 'off',
},
statePath: path.join(temp, 'copilot-off-data', '.ponytail-active'),
},
]) {
fs.mkdirSync(path.dirname(statePath), { recursive: true });
fs.writeFileSync(statePath, 'full');
const offResult = run('ponytail-activate.js', env);
assert.equal(offResult.status, 0, offResult.stderr);
assert.equal(offResult.stdout, '', `${label} SessionStart must stay silent when ponytail is off`);
assert.equal(fs.existsSync(statePath), false, `${label} stale mode state must be cleared`);
}

// USERPROFILE alongside HOME: os.homedir() reads USERPROFILE on Windows, HOME on POSIX.
const codexEnv = {
HOME: home,
Expand Down