test: port additional SubagentStart matcher coverage from #522 - #699
Open
dhedhialy wants to merge 3 commits into
Open
test: port additional SubagentStart matcher coverage from #522#699dhedhialy wants to merge 3 commits into
dhedhialy wants to merge 3 commits into
Conversation
Adds PONYTAIL_SUBAGENT_MATCHER env var support to the SubagentStart hook. When set, the hook reads agent_type from stdin and only injects ponytail instructions when the agent type matches the regex. Opt-in by default (no env var = inject all subagents, preserving backward compatibility). Fixes DietrichGebert#506
…docs Three fixes per review feedback on PR DietrichGebert#507: 1. No-matcher path stays synchronous and stdin-independent (no Windows regression) 2. Regex construction is guarded by try/catch so invalid regex doesn't crash 3. PONYTAIL_SUBAGENT_MATCHER documented in README.md alongside DEFAULT_MODE Also added test coverage for invalid regex and absent agent_type (fail-open).
…ert#522 Adds three test cases and the harness-hygiene delete per review feedback: - case-insensitive unanchored match (General-purpose against general|plan) - anchored ^general$ rejecting superset general-purpose - no-matcher path with empty stdin (proves DietrichGebert#443 Windows fix) - delete process.env.PONYTAIL_SUBAGENT_MATCHER to prevent CI env leaks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports matcher coverage for SubagentStart from #522.