fix(audit): require a whole-tree caller check before delete: (#679) - #714
Open
szsunyuan wants to merge 1 commit into
Open
fix(audit): require a whole-tree caller check before delete: (#679)#714szsunyuan wants to merge 1 commit into
szsunyuan wants to merge 1 commit into
Conversation
…hGebert#679) Stop delete: findings from asserting "no callers" without grepping tests, and record the scanned commit so a stale report is obvious. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ponytail-auditcould emitdelete:as "no callers" without grepping tests, fixtures, or string/dynamic refs. One Hunt line now requires that check; a symbol used only by tests is still used.git rev-parse --short HEAD(no network;unknown baseoutside git) and a standing caveat to re-verify against current HEAD before applying. Nogit fetch/ behind-upstream probe — those fail closed as "current" (ponytail-audit:delete:findings assert "no callers" with no required whole-tree check, and output records no base commit #679).Test plan
node scripts/check-rule-copies.jsnode scripts/check-versions.js(still 4.9.0)git diff --checknpm test— 84 root + 23 pi-extension + 3 ponytail-mcpCloses #679