Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Simplify study dictionary creation #107

Merged
merged 3 commits into from
Feb 27, 2023

Conversation

Leengit
Copy link
Collaborator

@Leengit Leengit commented Feb 23, 2023

Instead of assigning each individual dictionary key-value pair in its own Python expression, more concisely and clearly assign them all in one combined Python expression, using the standard dict(...) constructor. (This is related to Issue #94 but does not close it).

@Leengit Leengit added the documentation Improvements or additions to documentation label Feb 23, 2023
@Leengit Leengit requested a review from cooperlab February 23, 2023 19:41
@Leengit Leengit self-assigned this Feb 23, 2023
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@Leengit
Copy link
Collaborator Author

Leengit commented Feb 23, 2023

The second commit shortens tile_overlap_width to overlap_width and tile_overlap_height to overlap_height.

@Leengit Leengit force-pushed the convenience_function branch from e0cac00 to bbf373c Compare February 23, 2023 21:46
@Leengit
Copy link
Collaborator Author

Leengit commented Feb 23, 2023

The recent force push of the second commit additionally records these overlap values in the study and slide dictionaries so that the user need not try to derive the overlap values from the resulting tile positions. Slides can have and record different overlap values from each other. The study-wide value is either set directly by the user, or is taken from the first use of TilesByGridAndMask in the study. Creation of a TilesByGridAndMaskobject without specifying overlaps now defaults to the study-wide values, if available, else zero. Previously the default was simply zero. This closes Issue #93.

@Leengit Leengit force-pushed the convenience_function branch from bbf373c to 45c32b5 Compare February 24, 2023 14:31
@Leengit
Copy link
Collaborator Author

Leengit commented Feb 24, 2023

Force push just now, rebases to current master.

@Leengit Leengit force-pushed the convenience_function branch from 45c32b5 to 80c7e2a Compare February 24, 2023 14:56
@Leengit
Copy link
Collaborator Author

Leengit commented Feb 24, 2023

The third commit closes Issue #104.

@Leengit Leengit linked an issue Feb 24, 2023 that may be closed by this pull request
@Leengit Leengit force-pushed the convenience_function branch from 9596fdb to dc20cdd Compare February 27, 2023 18:43
@Leengit Leengit merged commit 4dfa978 into DigitalSlideArchive:master Feb 27, 2023
@Leengit Leengit deleted the convenience_function branch February 27, 2023 18:53
@Leengit Leengit linked an issue Mar 17, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose the list of tiles Capture overlap parameters in study
1 participant