Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update boundary detection in FSD feature extraction #1143

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

FattanePourakpour
Copy link
Collaborator

np.argwhere does not trace boundaries accurately; instead, trace_object_boundaries is used.

@cooperlab
Copy link
Contributor

@FattanePourakpour please address the complex curvature problem also mentioned in Issue #1139 and then let's look at getting the tests to pass.

Most tests compare to stored values so we would need to generate new values since the new algorithm is fundamentally changed.

@manthey
Copy link
Contributor

manthey commented Nov 1, 2024

@FattanePourakpour I see you have some commits why say "black". The codebase predates the existence of black and uses flake8 and autopep8. tox -e format will apply the autopep8 rules. They differ from black (for instance, preferring single quotes), and linting will fail with black's rules.

@FattanePourakpour
Copy link
Collaborator Author

@manthey thank you for the clarification. I will do tox -e format and commit again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants