Allow diligent to link a static DirectXShaderCompiler #723
+39
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
TheMostDiligent
left a comment
TheMostDiligent
left a comment
There was a problem hiding this comment.
This change makes sense, there are few minor questions + formatting.
Comment on lines
+152
to
+153
| LLVMSupport | ||
| dxcompiler |
Contributor
There was a problem hiding this comment.
Why are these public dependencies?
| ) | ||
| endif() | ||
| if (CMAKE_CXX_COMPILER_ID MATCHES "Clang" OR CMAKE_CXX_COMPILER_ID MATCHES "GNU") | ||
| target_link_libraries(Diligent-ShaderTools PRIVATE dl) |
Contributor
There was a problem hiding this comment.
I think that dl should not be needed when linking statically - can be in the else() branch
| cmake_policy(SET CMP0079 NEW) | ||
| target_link_libraries(SPIRV-Tools-opt | ||
| PUBLIC | ||
| LLVMSupport |
Contributor
There was a problem hiding this comment.
Why is it public dependency?
Also, why is this dependency needed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a flag (off by default) to allow diligent to use a statically-linked DirectXShaderCompiler