stylo_taffy: convert grid-template-areas template size (width / row count) to Taffy - #603
Closed
nicoburns wants to merge 8 commits into
Closed
stylo_taffy: convert grid-template-areas template size (width / row count) to Taffy#603nicoburns wants to merge 8 commits into
nicoburns wants to merge 8 commits into
Conversation
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
staging-devin-ai-integration
Bot
force-pushed
the
devin/1785836560-grid-template-areas-size
branch
from
August 5, 2026 15:23
d20dc84 to
e47a970
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Companion to DioxusLabs/taffy#1024, which changes
Style::grid_template_areastoOption<GridTemplateAreas<S>>carrying the explicit template size, and addsgrid_template_area_{row,column}_counttoGridContainerStyle. This lets templates with unnamed (.) cells beyond the named-area extents (e.g.grid-template-areas: "a .") size the explicit grid correctly.Stylo's computed
TemplateAreasalready stores this:width(column count) andstrings(one per row). The conversion now passes both through:Draft: depends on unreleased Taffy changes, temporarily pulled in via a
[patch.crates-io]now pointing at the DioxusLabs/taffy#1015 branch (sparseCellOccupancyMatrix, based on main and hence also including #1024) — to be replaced once a Taffy release containing both lands.Note: the WPT test that motivated this (
css/css-grid/placement/grid-container-change-grid-tracks-recompute-child-positions-001.html) currently reports CRASH (UNK) in the WPT runner both before and after this change (unsupported test type), so it can't be used for verification here; the behavior is covered by the hand-written test in taffy#1021/#1024.Link to Devin session: https://dioxus.staging.devinenterprise.com/sessions/b738b4844c184963b4e5b0bb846df49a
Requested by: @nicoburns
WPT results
166 newly passing, 8 newly failing (net +158), 1 other status change.
Full diff (175 changed tests)
Generated by the WPT workflow.