Clip scrollable_overflow to border box for overflow:hidden/clip - #604
Closed
jerry4718 wants to merge 1 commit into
Closed
Clip scrollable_overflow to border box for overflow:hidden/clip#604jerry4718 wants to merge 1 commit into
jerry4718 wants to merge 1 commit into
Conversation
When an element has overflow:hidden or overflow:clip on an axis, its scrollable_overflow now gets clipped to the border box on that axis. This prevents hit testing from matching children that are visually clipped, which caused incorrect cursor and hover state when a child with a transform escaped its parent's overflow:hidden clipping.
Member
|
I definitely want to fix this, but I'm not convinced this is the right place. I think the fix probably ought to go in the hit testing code. Because the scrollable_overflow is also used for actual scrolling (which applies to Overflow::Hidden nodes which are programmatically scrollable!) |
Contributor
Author
|
I reopened it at #612 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an element has overflow:hidden or overflow:clip on an axis, its scrollable_overflow now gets clipped to the border box on that axis. This prevents hit testing from matching children that are visually clipped, which caused incorrect cursor and hover state when a child with a transform escaped its parent's overflow:hidden clipping.
WPT results
No changes in test results compared to
main.Generated by the WPT workflow.