Fix checkbox checkedness not updating when checked attribute is cleared - #610
Open
nicoburns wants to merge 1 commit into
Open
Fix checkbox checkedness not updating when checked attribute is cleared#610nicoburns wants to merge 1 commit into
nicoburns wants to merge 1 commit into
Conversation
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes DioxusLabs/dioxus#5282 (signal-driven
checkedon<input type="checkbox">updates once then sticks).Root cause: dioxus-native-dom translates a falsy
checkedvalue intoDocumentMutator::clear_attribute, butclear_attributeonly removed the attribute fromelement.attrs— it never updated the element's checkedness stored inSpecialElementData::CheckboxInput. Sofalse -> trueworked (viaset_attribute→set_input_checked_state), buttrue -> falseleft the checkbox visually checked.Fix in
clear_attribute:This runs even when the attribute wasn't present, since checkedness can also be set by a user click without the attribute ever existing.
Adds regression tests in
tests/blitz-tests/tests/checkbox_checked.rsdriving a checkbox via a Dioxus prop through true/false transitions (both failed before the fix).Link to Devin session: https://dioxus.staging.devinenterprise.com/sessions/9d81d7c5e6f24e0e92d3da00b4f798ab
Requested by: @nicoburns
WPT results
No changes in test results compared to
main.Generated by the WPT workflow.