Drop renderer surface before window to fix segfault on close (Wayland) - #611
Merged
Merged
Conversation
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #355 (segfault when closing the window on Linux/Wayland).
The GPU surface was outliving the window/display it was attached to.
dioxus_native::launch_cfg_with_propskept an extraDioxusNativeWindowRendererclone alive as a local:Because the renderer is
Rc-shared (and also provided as a vdom context), dropping theViewonCloseRequesteddid not drop the inner renderer, so the wgpuSurfacewas only destroyed afterrun_appreturned and the event loop / Wayland connection had been torn down — the driver then dereferences freed display memory.Two changes:
blitz-shell:impl Drop for Viewnow callsself.renderer.suspend(), which releases the surface (RenderState::Suspended) while the window and event loop are still alive — robust regardless of outstanding renderer clones.dioxus-native: passrendererintoWindowConfigby value instead of keeping a stray clone alive pastrun_app.Not reproduced locally (headless VM, no Wayland/NVIDIA); verified with
cargo check,cargo clippy, andcargo test --workspace(all green).Link to Devin session: https://dioxus.staging.devinenterprise.com/sessions/0caa615da22344ffb73a7ff21bcfca0f
Requested by: @nicoburns
WPT results
No changes in test results compared to
main.Generated by the WPT workflow.