Move focus backwards on Shift+Tab - #617
Merged
Merged
Conversation
The Tab handler always called focus_next_node, so Shift+Tab moved focus forwards like a plain Tab and there was no way to reach the previous control from the keyboard. Add prev_node, the reverse-document-order mirror of next_node (step to the deepest last descendant of the preceding sibling, or up to the parent, wrapping around at the start of the document), expose it as focus_prev_node, and dispatch to it when the shift modifier is set. Signed-off-by: Dietmar Maurer <dietmar@proxmox.com>
nicoburns
approved these changes
Aug 5, 2026
nicoburns
enabled auto-merge (squash)
August 5, 2026 15:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Tab handler always called focus_next_node, so Shift+Tab moved focus forwards like a plain Tab and there was no way to reach the previous control from the keyboard.
Add prev_node, the reverse-document-order mirror of next_node (step to the deepest last descendant of the preceding sibling, or up to the parent, wrapping around at the start of the document), expose it as focus_prev_node, and dispatch to it when the shift modifier is set.
WPT results
No changes in test results compared to
main.Generated by the WPT workflow.