Map display:flow-root to taffy item_is_flow_root (BFC beside floats) - #626
Closed
nicoburns wants to merge 1 commit into
Closed
Map display:flow-root to taffy item_is_flow_root (BFC beside floats)#626nicoburns wants to merge 1 commit into
nicoburns wants to merge 1 commit into
Conversation
…hes a BFC Bumps taffy rev to include Style::item_is_flow_root / CoreStyle::is_flow_root (DioxusLabs/taffy#1060). flow-root boxes now avoid floats and do not collapse margins with their parent's BFC.
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Map
display: flow-rootto Taffy's newStyle::item_is_flow_root/CoreStyle::is_flow_root(DioxusLabs/taffy#1060) so that flow-root boxes establish a new Block Formatting Context: they avoid floats (CSS2 §9.5) and don't collapse margins with their parent's BFC. PreviouslyDisplayInside::FlowRootwas converted to a plainDisplay::Blockthat participated in the parent's BFC, sodisplay:flow-rootboxes overlapped floats.Also bumps the pinned taffy rev to
6e811a8b(the DioxusLabs/taffy#1060 branch), which additionally fixes BFC-beside-float full-height overlap, negative-margin, and negative-inset edge cases. Once taffy#1060 merges to main the rev should be bumped to the merge commit.Based on #625. WPT
css/CSS2/floats+css/CSS2/floats-clearvs #625: 195 → 211 PASS (16 newly passing, incl. floats-wrap-bfc-004, floats-wrap-bfc-with-margin-004/005/010, floats-bfc-003, floats-wrap-top-below-bfc-001–003 l/r), 0 regressions, 0 crashes.Link to Devin session: https://app.devin.ai/sessions/bd32f9420a3346a0be428cc02c532d0d
Requested by: @nicoburns
WPT results
270 newly passing, 12 newly failing (net +258), 1 other status change.
Full diff (283 changed tests)
Generated by the WPT workflow.