Preserve known dimensions in empty inline layout short-circuit - #633
Merged
nicoburns merged 2 commits intoAug 8, 2026
Conversation
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
… inline short-circuit
nicoburns
deleted the
devin/1786150337-flex-item-empty-inline-known-dims
branch
August 8, 2026 01:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the
css/css-flexbox/flexible-box-float.htmlregression on #625.When an inline formatting context contains only out-of-flow content (all children absolutely positioned or floated — e.g. a
<p> </p>flex item whose only text is whitespace and whose box is floated),compute_inline_layoutshort-circuits and returnedSize::ZERO, discarding the definiteknown_dimensionstaffy passed for the item (its flexed target size, e.g.300x30). The flex items therefore collapsed to0x0and the test's red fail-flag became visible.Together with DioxusLabs/taffy#1081 (which fixes
flexbox-min-height-auto-002b.html), both flexbox regressions on #625 pass. Verified with the WPT runner andcargo fmt/clippy.Link to Devin session: https://dioxus.staging.devinenterprise.com/sessions/40e9a29868044e77a6dbf77a7b4b11e3
Requested by: @nicoburns
WPT results
8 newly passing, 2 newly failing (net +6).
Full diff (10 changed tests)
Generated by the WPT workflow.