Fix content at negative positions contributing the scroll size (bump taffy) - #731
Merged
Conversation
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps taffy to pick up DioxusLabs/taffy#1116: content overflowing a box past its scroll origin (e.g. Bulma's off-screen absolutely positioned nav dropdowns at negative x) no longer inflates
content_size, so it stops propagating as spurious scrollable overflow to the root.Before: https://bulma.io/documentation root reported
content_size=1256at width 1200 (56px horizontal scroll). After:scroll_width=0(csskit.rs also still 0).Note: the taffy rev is currently pinned to the PR-branch commit
e2348db9; should be re-pinned to the main commit once DioxusLabs/taffy#1116 merges (same as #727/#728).Link to Devin session: https://dioxus.staging.devinenterprise.com/sessions/b6f5529e9a3e4823b603788b475ab109
Requested by: @nicoburns
WPT results
3 newly passing, 0 newly failing (net +3).
Full diff (3 changed tests)
Generated by the WPT workflow.