Wire up contain: layout and contain: paint to Taffy - #752
Merged
Conversation
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
nicoburns
enabled auto-merge (squash)
August 19, 2026 11:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates Taffy to a revision that includes the new
containstyle (DioxusLabs/taffy#1128) and wires up Stylo's computedcontainto it:stylo_taffy::convert::contain(input: stylo::Contain, display: stylo::Display) -> taffy::Containmaps theLAYOUTandPAINTflags (other flags have no Taffy layout effect). Containment is not applied to non-atomic inline-level boxes (display: inlinewithinside: flow), per css-contain-1's applicability rules.TaffyStyloStyleimplements the newCoreStyle::contain()accessor, and the eagerto_taffy_styleconversion setscontainas well.compute_layout_damagein blitz-dom now treats a change tocontainas requiring box-tree rebuild, since containment changes formatting-context structure (float containment, margin collapsing).WPT
css/css-containresults: 248 tests passing vs 239 on main (+11 newly passing: independent formatting context, float containment, margin collapsing, and baseline suppression tests; -2:contain-layout-dynamic-004/005.html, which require JavaScript to apply containment dynamically and previously only passed vacuously because both test and ref rendered without containment).Link to Devin session: https://dioxus.staging.devinenterprise.com/sessions/c903534a83f54a6daf2f68f4cc38cf72
Requested by: @nicoburns
WPT results
11 newly passing, 2 newly failing (net +9).
Full diff (13 changed tests)
Generated by the WPT workflow.