Fix atomic-inline baseline export, empty line boxes and root decoration baseline - #834
Closed
nicoburns wants to merge 2 commits into
Closed
Conversation
…seline - Inline-blocks that are block-axis scroll containers export no baseline (bottom margin edge is used); other atomic inlines (flex/grid/table) keep their content baseline, clamped to the border box when scrollable. contain: layout boxes export no baseline. - Atomic inlines with a baseline may reserve negative space in the line (negative vertical margins) and are positioned from that baseline. - An inline root with no text and no inline boxes is a zero-height line box and exports no baselines. - Text decorations on the inline root fall back to the line baseline rather than the (vertical-align shifted) first run's baseline. - Repin parley to ac4c61c33c5bbc63303570b336b4e27cfa0cdd83.
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes for regressions in the WPT diff of #832 that are actual bugs in the
vertical-alignmapping (full triage report is posted as a comment on #832). Repins parley to DioxusLabs/parley#22 (ac4c61c33c5bbc63303570b336b4e27cfa0cdd83).blitz-dom/src/layout/inline.rs— atomic inlineInlineBoxconstruction:contain: layoutboxes export none. Fixesbaseline-of-scrollable-1a,contain-layout-baseline-001/005, keepsflex-baseline-overflow-hiddenpassing.ibox.y + margin.top(notmargin.top.max(0)); the.max(0)clamp only applies to baseline-less boxes. Fixesflexbox_inline.empty-span-size-002.blitz-paint/src/text.rs— when the inline root hastext-decorationbut no run of its own,flush_line_decorationsfell back to the first descendant run's geometry, including itsvertical-align-shifted baseline. It now uses the line baseline for the root. Fixestext-decoration-va-length-001.Full
css/WPT run vs #832 head: 18 tests FAIL⇒PASS, 1 new failure (css-contain/contain-size-064: a size-contained grid with an ::afternow has a non-zero NBSP min-content width — pre-existing missingcontain: sizesupport in Taffy, exposed by the Parley NBSP fix).Link to Devin session: https://dioxus.staging.devinenterprise.com/sessions/5c4401ef6292427a952400c36ae85272
Open in Devin Desktop: https://dioxus.staging.devinenterprise.com/desktop/session/5c4401ef6292427a952400c36ae85272?variant=devin-insiders
Requested by: @nicoburns
WPT results
Subtests: 311 newly passing, 45 newly failing (net +266).
Full diff (259 changed tests)
Generated by the WPT workflow.