Populate AccessKit node bounds from layout - #842
Open
nicoburns wants to merge 1 commit into
Open
Conversation
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
staging-devin-ai-integration
Bot
force-pushed
the
devin/1788875037-accesskit-bounds
branch
from
September 8, 2026 13:48
b39b705 to
e8841db
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AccessKit nodes built by
BaseDocument::build_accessibility_treenever hadboundsset, so every node reported a 0×0 frame (macOS AX dump showed all content at(0,1200) 0x0). VoiceOver's cursor navigation skips zero-size nodes, so only focus-driven announcements worked. This is platform-independent (AT-SPI/UIA use the same property); the macOSset_window_boundsno-op inaccesskit_xplatis not the cause — the macOS adapter derives the frame from the NSView and only needs per-nodebounds.build_accessibility_nodenow sets:accesskit_consumerexpects;accesskit_macos::to_ns_rectdivides bybackingScaleFactor).get_client_bounding_rectalready handles inline (non-atomic) elements via per-line fragment rects and subtractsviewport_scroll.layout_data()panics for them).Adds a unit test checking element/text bounds at scale 2.0.
Found during the macOS smoke test of #614 (pre-existing on
main).Link to Devin session: https://dioxus.staging.devinenterprise.com/sessions/a737411590c54bbb833aa9167f89ac51
Open in Devin Desktop: https://dioxus.staging.devinenterprise.com/desktop/session/a737411590c54bbb833aa9167f89ac51?variant=devin-insiders
Requested by: @nicoburns
WPT results
No changes in test results compared to
main.Generated by the WPT workflow.