Repin parley to the whitespace-collapsing branch (parley#25) - #857
Open
nicoburns wants to merge 1 commit into
Open
Repin parley to the whitespace-collapsing branch (parley#25)#857nicoburns wants to merge 1 commit into
nicoburns wants to merge 1 commit into
Conversation
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
staging-devin-ai-integration
Bot
force-pushed
the
devin/1786131935-parley-git-dep
branch
from
September 10, 2026 20:57
d02be35 to
e349ed3
Compare
staging-devin-ai-integration
Bot
force-pushed
the
devin/1789072599-parley-whitespace-repin
branch
from
September 10, 2026 20:57
b93c634 to
51a7c6e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Repins the parley git dependency onto DioxusLabs/parley#25 (
ba6037d, rebased on parley main2b14269), which implements CSS Text phase-I whitespace collapsing across style-span and inline-box boundaries instead of trimming per span.No Blitz source changes are needed — the branch is API-compatible with parley main, so this is only
Cargo.toml/Cargo.lock.Expected effects on the text WPT suites (numbers left to CI): improvements concentrated in
css/CSS2/text/white-space-*andcss-text/white-space/*, pluscss-writing-modes/abs-pos-non-replaced-*—set_white_space_modenow flushes buffered text, so an out-of-flow inline box gets its true source offset rather than one lagging behind uncommitted text. Known remaining failures on this branch arewhite-space-processing-024/027, wherepre-lineis mapped toWhiteSpaceCollapse::Preserveinpackages/blitz-dom/src/stylo_to_parley.rsbecause parley has noPreserveBreaksmode yet.Link to Devin session: https://dioxus.staging.devinenterprise.com/sessions/a9f0131145654530a87ad078d0d3c42b
Open in Devin Desktop: https://dioxus.staging.devinenterprise.com/desktop/session/a9f0131145654530a87ad078d0d3c42b?variant=devin-insiders
Requested by: @nicoburns
WPT results
Subtests: 500 newly passing, 106 newly failing (net +394).
Full diff (421 changed tests)
Generated by the WPT workflow.