Add top/bottom vertical alignment for inline boxes - #7
Open
nicoburns wants to merge 1 commit into
Open
Conversation
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This was referenced Aug 11, 2026
staging-devin-ai-integration
Bot
force-pushed
the
devin/1786406429-line-strut
branch
from
August 11, 2026 00:21
ce32fe8 to
bb7159a
Compare
staging-devin-ai-integration
Bot
changed the base branch from
main
to
devin/1786407000-stack-2
August 11, 2026 00:21
staging-devin-ai-integration
Bot
force-pushed
the
devin/1786406429-line-strut
branch
from
August 18, 2026 21:53
bb7159a to
95a9ff1
Compare
staging-devin-ai-integration
Bot
force-pushed
the
devin/1786407000-stack-2
branch
from
August 18, 2026 21:53
e06ca44 to
98db0dd
Compare
staging-devin-ai-integration
Bot
force-pushed
the
devin/1786407000-stack-2
branch
from
September 1, 2026 20:08
98db0dd to
fa087de
Compare
staging-devin-ai-integration
Bot
force-pushed
the
devin/1786406429-line-strut
branch
from
September 2, 2026 15:55
95a9ff1 to
5335bd6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LLM Contributions: This PR (code and description) was authored by Devin, directed and reviewed by @nicoburns.
Top PR of the stack (#9 → #10 → #7).
Implements
vertical-align: top/bottomfor inline boxes, which parley previously treated as baseline-aligned — fixing thefloats-wrap-bfc-002-*WPT tests (Group C2 in DioxusLabs/blitz#627) where a strut descent was wrongly added belowvertical-align: bottominline-blocks.InlineBoxgainsvertical_align: InlineBoxVerticalAlign(Baseline(default) /Top/Bottom).InlineBoxAlignmentgains aTopOrBottom { height }variant: such boxes grow the line box (tracked asLineBoxMetrics::top_or_bottom_box_height, with extra space added below the baseline) without moving the baseline.GlyphRunIterpositions them flush with the line'sblock_min_coord/block_max_coordinstead of relative to the baseline.vertical_alignfield initializers.Changelog
Link to Devin session: https://dioxus.staging.devinenterprise.com/sessions/6ab608fbe6fb46479d6dab03fedceb25