Skip to content

Add top/bottom vertical alignment for inline boxes - #7

Open
nicoburns wants to merge 1 commit into
devin/1786407000-stack-2from
devin/1786406429-line-strut
Open

Add top/bottom vertical alignment for inline boxes#7
nicoburns wants to merge 1 commit into
devin/1786407000-stack-2from
devin/1786406429-line-strut

Conversation

@nicoburns

@nicoburns nicoburns commented Aug 11, 2026

Copy link
Copy Markdown
Member

LLM Contributions: This PR (code and description) was authored by Devin, directed and reviewed by @nicoburns.

Top PR of the stack (#9#10#7).

Implements vertical-align: top/bottom for inline boxes, which parley previously treated as baseline-aligned — fixing the floats-wrap-bfc-002-* WPT tests (Group C2 in DioxusLabs/blitz#627) where a strut descent was wrongly added below vertical-align: bottom inline-blocks.

  • InlineBox gains vertical_align: InlineBoxVerticalAlign (Baseline (default) / Top / Bottom).
  • InlineBoxAlignment gains a TopOrBottom { height } variant: such boxes grow the line box (tracked as LineBoxMetrics::top_or_bottom_box_height, with extra space added below the baseline) without moving the baseline.
  • GlyphRunIter positions them flush with the line's block_min_coord/block_max_coord instead of relative to the baseline.
  • Test/example changes are mechanical vertical_align field initializers.

Changelog

Added

  • InlineBox::vertical_align (InlineBoxVerticalAlign::Baseline/Top/Bottom) to align an inline box with the top or bottom of the line box instead of the baseline.

Link to Devin session: https://dioxus.staging.devinenterprise.com/sessions/6ab608fbe6fb46479d6dab03fedceb25

@nicoburns nicoburns self-assigned this Aug 11, 2026
@staging-devin-ai-integration

Copy link
Copy Markdown

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR that start with 'DevinAI' or '@devin'.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment, CI, and merge conflict monitoring

@staging-devin-ai-integration
staging-devin-ai-integration Bot force-pushed the devin/1786406429-line-strut branch from ce32fe8 to bb7159a Compare August 11, 2026 00:21
@staging-devin-ai-integration
staging-devin-ai-integration Bot changed the base branch from main to devin/1786407000-stack-2 August 11, 2026 00:21
@staging-devin-ai-integration staging-devin-ai-integration Bot changed the title Add line-box strut support and top/bottom vertical alignment for inline boxes Add top/bottom vertical alignment for inline boxes Aug 12, 2026
@staging-devin-ai-integration
staging-devin-ai-integration Bot force-pushed the devin/1786406429-line-strut branch from bb7159a to 95a9ff1 Compare August 18, 2026 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant