Skip to content

Add regression tests for content measured at the unclamped style width #1095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
HelgeSverre wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add regression tests for content measured at the unclamped style width #1095

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6836bf9
Add regression tests for content measured at unclamped style width
HelgeSverre Aug 11, 2026
ccfd425
Convert measure clamp regressions to generated tests
HelgeSverre Aug 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions test_fixtures/flex/measure_child_with_fixed_width_clamped_by_max_width_intrinsic.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
<!DOCTYPE html>
<html lang="en">
<head>
<script src="../../scripts/gentest/test_helper.js"></script>
<link rel="stylesheet" type="text/css" href="../../scripts/gentest/test_base_style.css">
<title>
Intrinsically measure a flex child's content using its width clamped by max-width
</title>
</head>
<body>

<div id="test-root" style="flex-direction: column;">
<div style="flex-direction: column; width: 300px; max-width: 200px;">
<div>HHHH&ZeroWidthSpace;HHHH&ZeroWidthSpace;HHHH&ZeroWidthSpace;HHHH&ZeroWidthSpace;HHHH&ZeroWidthSpace;HHHH&ZeroWidthSpace;HHHH&ZeroWidthSpace;HHHH&ZeroWidthSpace;HHHH&ZeroWidthSpace;HHHH&ZeroWidthSpace;HHHH&ZeroWidthSpace;HHHH</div>
</div>
</div>

</body>
</html>
19 changes: 19 additions & 0 deletions test_fixtures/flex/measure_child_with_percent_width_clamped_by_max_width.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
<!DOCTYPE html>
<html lang="en">
<head>
<script src="../../scripts/gentest/test_helper.js"></script>
<link rel="stylesheet" type="text/css" href="../../scripts/gentest/test_base_style.css">
<title>
Measure a flex child's content using its width clamped by max-width
</title>
</head>
<body>

<div id="test-root" style="flex-direction: column; width: 300px;">
<div style="flex-direction: column; width: 100%; max-width: 200px;">
<div>HHHH&ZeroWidthSpace;HHHH&ZeroWidthSpace;HHHH&ZeroWidthSpace;HHHH&ZeroWidthSpace;HHHH&ZeroWidthSpace;HHHH&ZeroWidthSpace;HHHH&ZeroWidthSpace;HHHH&ZeroWidthSpace;HHHH&ZeroWidthSpace;HHHH&ZeroWidthSpace;HHHH&ZeroWidthSpace;HHHH</div>
</div>
</div>

</body>
</html>
19 changes: 19 additions & 0 deletions ...ml/flex/measure_child_with_fixed_width_clamped_by_max_width_intrinsic__border_box_ltr.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
<test name="measure_child_with_fixed_width_clamped_by_max_width_intrinsic__border_box_ltr" use-rounding="true">
<viewport width="max-content" height="max-content"/>
<input>
<div direction="ltr" flex-direction="column">
<div direction="ltr" flex-direction="column" width="300px" max-width="200px">
<text direction="ltr">
HHHH​HHHH​HHHH​HHHH​HHHH​HHHH​HHHH​HHHH​HHHH​HHHH​HHHH​HHHH
</text>
</div>
</div>
</input>
<expectations>
<node x="0" y="0" width="200" height="30">
<node x="0" y="0" width="200" height="30">
<node x="0" y="0" width="200" height="30"/>
</node>
</node>
</expectations>
</test>
19 changes: 19 additions & 0 deletions ...ml/flex/measure_child_with_fixed_width_clamped_by_max_width_intrinsic__border_box_rtl.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
<test name="measure_child_with_fixed_width_clamped_by_max_width_intrinsic__border_box_rtl" use-rounding="true">
<viewport width="max-content" height="max-content"/>
<input>
<div direction="rtl" flex-direction="column">
<div direction="rtl" flex-direction="column" width="300px" max-width="200px">
<text direction="rtl">
HHHH​HHHH​HHHH​HHHH​HHHH​HHHH​HHHH​HHHH​HHHH​HHHH​HHHH​HHHH
</text>
</div>
</div>
</input>
<expectations>
<node x="0" y="0" width="200" height="30">
<node x="0" y="0" width="200" height="30">
<node x="0" y="0" width="200" height="30"/>
</node>
</node>
</expectations>
</test>
19 changes: 19 additions & 0 deletions ...l/flex/measure_child_with_fixed_width_clamped_by_max_width_intrinsic__content_box_ltr.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
<test name="measure_child_with_fixed_width_clamped_by_max_width_intrinsic__content_box_ltr" use-rounding="true">
<viewport width="max-content" height="max-content"/>
<input>
<div box-sizing="content-box" direction="ltr" flex-direction="column">
<div box-sizing="content-box" direction="ltr" flex-direction="column" width="300px" max-width="200px">
<text box-sizing="content-box" direction="ltr">
HHHH​HHHH​HHHH​HHHH​HHHH​HHHH​HHHH​HHHH​HHHH​HHHH​HHHH​HHHH
</text>
</div>
</div>
</input>
<expectations>
<node x="0" y="0" width="200" height="30">
<node x="0" y="0" width="200" height="30">
<node x="0" y="0" width="200" height="30"/>
</node>
</node>
</expectations>
</test>
19 changes: 19 additions & 0 deletions ...l/flex/measure_child_with_fixed_width_clamped_by_max_width_intrinsic__content_box_rtl.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
<test name="measure_child_with_fixed_width_clamped_by_max_width_intrinsic__content_box_rtl" use-rounding="true">
<viewport width="max-content" height="max-content"/>
<input>
<div box-sizing="content-box" direction="rtl" flex-direction="column">
<div box-sizing="content-box" direction="rtl" flex-direction="column" width="300px" max-width="200px">
<text box-sizing="content-box" direction="rtl">
HHHH​HHHH​HHHH​HHHH​HHHH​HHHH​HHHH​HHHH​HHHH​HHHH​HHHH​HHHH
</text>
</div>
</div>
</input>
<expectations>
<node x="0" y="0" width="200" height="30">
<node x="0" y="0" width="200" height="30">
<node x="0" y="0" width="200" height="30"/>
</node>
</node>
</expectations>
</test>
19 changes: 19 additions & 0 deletions tests/xml/flex/measure_child_with_percent_width_clamped_by_max_width__border_box_ltr.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
<test name="measure_child_with_percent_width_clamped_by_max_width__border_box_ltr" use-rounding="true">
<viewport width="max-content" height="max-content"/>
<input>
<div direction="ltr" flex-direction="column" width="300px">
<div direction="ltr" flex-direction="column" width="100%" max-width="200px">
<text direction="ltr">
HHHH​HHHH​HHHH​HHHH​HHHH​HHHH​HHHH​HHHH​HHHH​HHHH​HHHH​HHHH
</text>
</div>
</div>
</input>
<expectations>
<node x="0" y="0" width="300" height="30">
<node x="0" y="0" width="200" height="30">
<node x="0" y="0" width="200" height="30"/>
</node>
</node>
</expectations>
</test>
19 changes: 19 additions & 0 deletions tests/xml/flex/measure_child_with_percent_width_clamped_by_max_width__border_box_rtl.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
<test name="measure_child_with_percent_width_clamped_by_max_width__border_box_rtl" use-rounding="true">
<viewport width="max-content" height="max-content"/>
<input>
<div direction="rtl" flex-direction="column" width="300px">
<div direction="rtl" flex-direction="column" width="100%" max-width="200px">
<text direction="rtl">
HHHH​HHHH​HHHH​HHHH​HHHH​HHHH​HHHH​HHHH​HHHH​HHHH​HHHH​HHHH
</text>
</div>
</div>
</input>
<expectations>
<node x="0" y="0" width="300" height="30">
<node x="100" y="0" width="200" height="30">
<node x="0" y="0" width="200" height="30"/>
</node>
</node>
</expectations>
</test>
19 changes: 19 additions & 0 deletions tests/xml/flex/measure_child_with_percent_width_clamped_by_max_width__content_box_ltr.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
<test name="measure_child_with_percent_width_clamped_by_max_width__content_box_ltr" use-rounding="true">
<viewport width="max-content" height="max-content"/>
<input>
<div box-sizing="content-box" direction="ltr" flex-direction="column" width="300px">
<div box-sizing="content-box" direction="ltr" flex-direction="column" width="100%" max-width="200px">
<text box-sizing="content-box" direction="ltr">
HHHH​HHHH​HHHH​HHHH​HHHH​HHHH​HHHH​HHHH​HHHH​HHHH​HHHH​HHHH
</text>
</div>
</div>
</input>
<expectations>
<node x="0" y="0" width="300" height="30">
<node x="0" y="0" width="200" height="30">
<node x="0" y="0" width="200" height="30"/>
</node>
</node>
</expectations>
</test>
19 changes: 19 additions & 0 deletions tests/xml/flex/measure_child_with_percent_width_clamped_by_max_width__content_box_rtl.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
<test name="measure_child_with_percent_width_clamped_by_max_width__content_box_rtl" use-rounding="true">
<viewport width="max-content" height="max-content"/>
<input>
<div box-sizing="content-box" direction="rtl" flex-direction="column" width="300px">
<div box-sizing="content-box" direction="rtl" flex-direction="column" width="100%" max-width="200px">
<text box-sizing="content-box" direction="rtl">
HHHH​HHHH​HHHH​HHHH​HHHH​HHHH​HHHH​HHHH​HHHH​HHHH​HHHH​HHHH
</text>
</div>
</div>
</input>
<expectations>
<node x="0" y="0" width="300" height="30">
<node x="100" y="0" width="200" height="30">
<node x="0" y="0" width="200" height="30"/>
</node>
</node>
</expectations>
</test>
40 changes: 40 additions & 0 deletions tests/xml/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16067,6 +16067,26 @@ mod flex {
crate::run_xml_test("flex", "measure_child_constraint_padding_parent__content_box_rtl");
}

#[test]
fn measure_child_with_fixed_width_clamped_by_max_width_intrinsic__border_box_ltr() {
crate::run_xml_test("flex", "measure_child_with_fixed_width_clamped_by_max_width_intrinsic__border_box_ltr");
}

#[test]
fn measure_child_with_fixed_width_clamped_by_max_width_intrinsic__content_box_ltr() {
crate::run_xml_test("flex", "measure_child_with_fixed_width_clamped_by_max_width_intrinsic__content_box_ltr");
}

#[test]
fn measure_child_with_fixed_width_clamped_by_max_width_intrinsic__border_box_rtl() {
crate::run_xml_test("flex", "measure_child_with_fixed_width_clamped_by_max_width_intrinsic__border_box_rtl");
}

#[test]
fn measure_child_with_fixed_width_clamped_by_max_width_intrinsic__content_box_rtl() {
crate::run_xml_test("flex", "measure_child_with_fixed_width_clamped_by_max_width_intrinsic__content_box_rtl");
}

#[test]
fn measure_child_with_flex_grow__border_box_ltr() {
crate::run_xml_test("flex", "measure_child_with_flex_grow__border_box_ltr");
Expand Down Expand Up @@ -16147,6 +16167,26 @@ mod flex {
crate::run_xml_test("flex", "measure_child_with_min_size_greater_than_available_space__content_box_rtl");
}

#[test]
fn measure_child_with_percent_width_clamped_by_max_width__border_box_ltr() {
crate::run_xml_test("flex", "measure_child_with_percent_width_clamped_by_max_width__border_box_ltr");
}

#[test]
fn measure_child_with_percent_width_clamped_by_max_width__content_box_ltr() {
crate::run_xml_test("flex", "measure_child_with_percent_width_clamped_by_max_width__content_box_ltr");
}

#[test]
fn measure_child_with_percent_width_clamped_by_max_width__border_box_rtl() {
crate::run_xml_test("flex", "measure_child_with_percent_width_clamped_by_max_width__border_box_rtl");
}

#[test]
fn measure_child_with_percent_width_clamped_by_max_width__content_box_rtl() {
crate::run_xml_test("flex", "measure_child_with_percent_width_clamped_by_max_width__content_box_rtl");
}

#[test]
fn measure_flex_basis_overrides_measure__border_box_ltr() {
crate::run_xml_test("flex", "measure_flex_basis_overrides_measure__border_box_ltr");
Expand Down